Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 48753003: [webcrypto] Make WebCryptoKey nullable. (Closed)

Created:
7 years, 1 month ago by eroman
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Make WebCryptoKey nullable. This is a convenience for the embedder so it is easier to use as an out-parameter like: WebCryptoKey key = WebCryptoKey::createNull(); if (doSomethingThatMightFailOrCreateKey(&key)) { .. } On the other side of the Blink API, WebCryptoKey is never expected to be null. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M Source/core/platform/chromium/support/WebCrypto.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/exported/WebCryptoKey.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebCryptoKey.h View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
7 years, 1 month ago (2013-10-30 22:52:46 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-30 22:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/48753003/1
7 years, 1 month ago (2013-10-30 23:00:10 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 00:08:49 UTC) #4
Message was sent while issue was closed.
Change committed as 160989

Powered by Google App Engine
This is Rietveld 408576698