Experimentally isolate GetSaveFileName in a utility process.

Experimentally isolate GetSaveFileName in a utility process.

Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability.

BUG=73098
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291416

[erikwright (departed), 2014-08-19 14:36:12]

sky: PTAL.
jschuh: PTAL for new IPC message security. Again, these are
unsandboxed->unsandboxed.

[jschuh, 2014-08-19 16:05:02]

Rubberstamp ipc security lgtm (notes: unsandboxed<->unsandboxed)

[sky, 2014-08-19 17:02:51]

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
File ui/base/win/open_file_name_win.cc (right):

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
ui/base/win/open_file_name_win.cc:36: HMONITOR monitor1 =
::MonitorFromPoint(point, MONITOR_DEFAULTTONULL);
Why not MonitorFromWindow, get the work area and constrain? Seems simpler.

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
File ui/base/win/open_file_name_win.h (right):

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
ui/base/win/open_file_name_win.h:47: void
MaybeInstallWindowPositionHookForSaveAsOnXP();
Rather than hooking is there a way to force a particular location?

[erikwright (departed), 2014-08-19 17:09:15]

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
File ui/base/win/open_file_name_win.cc (right):

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
ui/base/win/open_file_name_win.cc:36: HMONITOR monitor1 =
::MonitorFromPoint(point, MONITOR_DEFAULTTONULL);
On 2014/08/19 17:02:51, sky wrote:
> Why not MonitorFromWindow, get the work area and constrain? Seems simpler.

I have no idea. This code is moved verbatim from its previous location (with the
exception of qualifying Win SDK functions with '::'). It seems best to keep it
as is.

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
File ui/base/win/open_file_name_win.h (right):

https://codereview.chromium.org/487453002/diff/20001/ui/base/win/open_file_na...
ui/base/win/open_file_name_win.h:47: void
MaybeInstallWindowPositionHookForSaveAsOnXP();
On 2014/08/19 17:02:51, sky wrote:
> Rather than hooking is there a way to force a particular location?

Possibly. Again, this is just existing code moved here to be re-used from either
the browser or utility process.

I would assume that the intention is that 99% of the time, allowing the built-in
machinery to act and remember the previous location is correct. And so we just
need to detect the 1% of the time that this gives bad results.

[sky, 2014-08-19 19:40:52]

Fair enough, LGTM

[erikwright (departed), 2014-08-21 18:30:24]

The CQ bit was checked by erikwright@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:32:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikwright@chromium.org/487453002/20001

[commit-bot: I haz the power, 2014-08-21 21:29:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-21 21:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:56:54]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[erikwright (departed), 2014-08-22 15:30:05]

The CQ bit was checked by erikwright@chromium.org

[commit-bot: I haz the power, 2014-08-22 15:30:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikwright@chromium.org/487453002/20001

[commit-bot: I haz the power, 2014-08-22 15:38:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 15:46:44]

Committed patchset #2 (20001) as 291416