Telemetry perf trybots: diff against master

Telemetry perf trybots: diff against master

git cl upload uses the tracking branch to diff against unless otherwise
specified. This change specifies the origin/master branch should be
used.

BUG=401180
Committed: https://crrev.com/31d566a65d3d80bc4261567494d970c1ecfb8b2c
Cr-Commit-Position: refs/heads/master@{#291689}

[tonyg, 2014-08-22 05:02:41]

Lgtm
On Aug 21, 2014 8:17 PM, <alancutter@chromium.org> wrote:

> Reviewers: sullivan, tonyg,
>
> Description:
> Telemetry perf trybots: diff against master
>
> git cl upload uses the tracking branch to diff against unless otherwise
> specified. This change specifies the origin/master branch should be
> used.
>
> BUG=401180
>
> Please review this at https://codereview.chromium.org/487433005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M tools/telemetry/telemetry/core/backends/remote/trybot_
> browser_finder.py
>
>
> Index: tools/telemetry/telemetry/core/backends/remote/trybot_
> browser_finder.py
> diff --git
a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
> b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
> index dba968f3630356b2434a8481c59de04bba0f3512..
> 56f7ea4c6dde1925fddba327c404a0d5b686f9e2 100644
> --- a/tools/telemetry/telemetry/core/backends/remote/trybot_
> browser_finder.py
> +++ b/tools/telemetry/telemetry/core/backends/remote/trybot_
> browser_finder.py
> @@ -133,7 +133,7 @@ class PossibleTrybotBrowser(possible_browser.
> PossibleBrowser):
>      # Upload the CL to rietveld and run a try job.
>      returncode, out, err = self._RunProcess([
>          'git', 'cl', 'upload', '-f', '--bypass-hooks', '-m',
> -        'CL for perf tryjob'
> +        'CL for perf tryjob', 'origin/master'
>      ])
>      if returncode:
>        logging.error('Could upload to reitveld, error %s', err)
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[alancutter (OOO until 2018), 2014-08-22 05:37:58]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:39:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alancutter@chromium.org/487433005/1

[commit-bot: I haz the power, 2014-08-22 05:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:39:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[alancutter (OOO until 2018), 2014-08-22 05:59:35]

On 2014/08/22 05:39:45, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Looks like maybe mixed case lgtms are not accepted.

[sullivan, 2014-08-22 08:09:29]

The CQ bit was checked by sullivan@chromium.org

[sullivan, 2014-08-22 08:09:30]

lgtm

[commit-bot: I haz the power, 2014-08-22 08:10:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alancutter@chromium.org/487433005/1

[commit-bot: I haz the power, 2014-08-22 09:41:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 09:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 09:45:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tonyg, 2014-08-22 17:20:05]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-08-22 17:20:06]

lgtm

[commit-bot: I haz the power, 2014-08-22 17:22:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alancutter@chromium.org/487433005/1

[commit-bot: I haz the power, 2014-08-22 19:05:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 19:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 19:38:06]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2014-08-25 14:34:22]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-08-25 14:34:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alancutter@chromium.org/487433005/20001

[commit-bot: I haz the power, 2014-08-25 15:31:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-25 16:08:50]

Committed patchset #2 (20001) as 7201c8ec600c6ab0a86c51d3f320f44ac5e0c917

[commit-bot: I haz the power, 2014-09-10 02:34:46]

Patchset 2 (id:??) landed as
https://crrev.com/31d566a65d3d80bc4261567494d970c1ecfb8b2c
Cr-Commit-Position: refs/heads/master@{#291689}