Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 48743004: Move InspectorBackendDispatcher::commandNames array from .data to .rodata section (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reenable compile assertion Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/CodeGeneratorInspectorStrings.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 OwnPtr<MessageDescriptor> descriptor = adoptPtr(rawDescriptor); 568 OwnPtr<MessageDescriptor> descriptor = adoptPtr(rawDescriptor);
569 OwnPtr<DebuggerTask> task = adoptPtr(new DebuggerTask(descriptor.release())) ; 569 OwnPtr<DebuggerTask> task = adoptPtr(new DebuggerTask(descriptor.release())) ;
570 PageScriptDebugServer::interruptAndRun(task.release(), v8::Isolate::GetCurre nt()); 570 PageScriptDebugServer::interruptAndRun(task.release(), v8::Isolate::GetCurre nt());
571 } 571 }
572 572
573 bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message) 573 bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message)
574 { 574 {
575 String commandName; 575 String commandName;
576 if (!InspectorBackendDispatcher::getCommandName(message, &commandName)) 576 if (!InspectorBackendDispatcher::getCommandName(message, &commandName))
577 return false; 577 return false;
578 return commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kDebugger_pauseCmd] 578 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd)
579 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kDebugger_setBreakpointCmd] 579 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd)
580 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kDebugger_setBreakpointByUrlCmd] 580 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd)
581 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kDebugger_removeBreakpointCmd] 581 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd)
582 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kDebugger_setBreakpointsActiveCmd] 582 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd)
583 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kProfiler_startCmd] 583 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kProfiler_startCmd)
584 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kProfiler_stopCmd] 584 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kProfiler_stopCmd)
585 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kProfiler_getCPUProfileCmd] 585 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kProfiler_getCPUProfileCmd)
586 || commandName == InspectorBackendDispatcher::commandNames[InspectorBack endDispatcher::kHeapProfiler_getHeapSnapshotCmd]; 586 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kHeapProfiler_getHeapSnapshotCmd);
587 } 587 }
588 588
589 void WebDevToolsAgent::processPendingMessages() 589 void WebDevToolsAgent::processPendingMessages()
590 { 590 {
591 PageScriptDebugServer::shared().runPendingTasks(); 591 PageScriptDebugServer::shared().runPendingTasks();
592 } 592 }
593 593
594 } // namespace WebKit 594 } // namespace WebKit
OLDNEW
« no previous file with comments | « Source/core/inspector/CodeGeneratorInspectorStrings.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698