Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: runtime/vm/assembler_ia32.cc

Issue 48743002: Do not directly load smi constants larger than a 16 bit payload on ia32. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/heap.h" 10 #include "vm/heap.h"
(...skipping 1927 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 } else { 1938 } else {
1939 ASSERT(object.IsNotTemporaryScopedHandle()); 1939 ASSERT(object.IsNotTemporaryScopedHandle());
1940 ASSERT(object.IsOld()); 1940 ASSERT(object.IsOld());
1941 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1941 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1942 EmitUint8(0xB8 + dst); 1942 EmitUint8(0xB8 + dst);
1943 buffer_.EmitObject(object); 1943 buffer_.EmitObject(object);
1944 } 1944 }
1945 } 1945 }
1946 1946
1947 1947
1948 void Assembler::LoadObjectSafely(Register dst, const Object& object) {
1949 if (Assembler::IsSafe(object)) {
1950 LoadObject(dst, object);
1951 } else {
1952 movl(dst,
1953 Immediate(reinterpret_cast<int32_t>(object.raw()) ^ jit_cookie_));
1954 xorl(dst, Immediate(jit_cookie_));
1955 }
1956 }
1957
1958
1948 void Assembler::PushObject(const Object& object) { 1959 void Assembler::PushObject(const Object& object) {
1949 if (object.IsSmi() || object.InVMHeap()) { 1960 if (object.IsSmi() || object.InVMHeap()) {
1950 pushl(Immediate(reinterpret_cast<int32_t>(object.raw()))); 1961 pushl(Immediate(reinterpret_cast<int32_t>(object.raw())));
1951 } else { 1962 } else {
1952 ASSERT(object.IsNotTemporaryScopedHandle()); 1963 ASSERT(object.IsNotTemporaryScopedHandle());
1953 ASSERT(object.IsOld()); 1964 ASSERT(object.IsOld());
1954 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1965 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1955 EmitUint8(0x68); 1966 EmitUint8(0x68);
1956 buffer_.EmitObject(object); 1967 buffer_.EmitObject(object);
1957 } 1968 }
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
2496 2507
2497 const char* Assembler::FpuRegisterName(FpuRegister reg) { 2508 const char* Assembler::FpuRegisterName(FpuRegister reg) {
2498 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 2509 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
2499 return xmm_reg_names[reg]; 2510 return xmm_reg_names[reg];
2500 } 2511 }
2501 2512
2502 2513
2503 } // namespace dart 2514 } // namespace dart
2504 2515
2505 #endif // defined TARGET_ARCH_IA32 2516 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698