Issue 487373002: EasyUnlock: Work around the ghost overlay from CSS animation.

Issue 487373002: EasyUnlock: Work around the ghost overlay from CSS animation. (Closed)

Created:
6 years, 4 months ago by xiyuan

Modified:
6 years, 4 months ago

Reviewers:
tbarzic

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

EasyUnlock: Work around the ghost overlay from CSS animation. BUG=404779 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743

Patch Set 2 : add blink bug to comment #

Patch Set 3 : fix ESC and click-close-button path #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	chrome/browser/resources/options/easy_unlock_turn_off_overlay.js	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

xiyuan

Hide the animated spinner then closeOverlay to work around bug 404859. I will get a ...

6 years, 4 months ago (2014-08-19 18:18:13 UTC) #1

tbarzic

lgtm https://codereview.chromium.org/487373002/diff/1/chrome/browser/resources/options/easy_unlock_turn_off_overlay.js File chrome/browser/resources/options/easy_unlock_turn_off_overlay.js (right): https://codereview.chromium.org/487373002/diff/1/chrome/browser/resources/options/easy_unlock_turn_off_overlay.js#newcode178 chrome/browser/resources/options/easy_unlock_turn_off_overlay.js:178: // TODO(xiyuan): Remove the workaround and call closeOverly ...

6 years, 4 months ago (2014-08-19 18:24:22 UTC) #2

xiyuan

https://codereview.chromium.org/487373002/diff/1/chrome/browser/resources/options/easy_unlock_turn_off_overlay.js File chrome/browser/resources/options/easy_unlock_turn_off_overlay.js (right): https://codereview.chromium.org/487373002/diff/1/chrome/browser/resources/options/easy_unlock_turn_off_overlay.js#newcode178 chrome/browser/resources/options/easy_unlock_turn_off_overlay.js:178: // TODO(xiyuan): Remove the workaround and call closeOverly directly. ...

6 years, 4 months ago (2014-08-19 20:12:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/487373002/20001

6 years, 4 months ago (2014-08-19 20:14:38 UTC) #5

xiyuan

Updated the patch to handle ESCAPE key and close button click so that it goes ...

6 years, 4 months ago (2014-08-19 20:40:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/487373002/40001

6 years, 4 months ago (2014-08-19 20:42:34 UTC) #10

commit-bot: I haz the power

Committed patchset #3 (40001) as 290743

6 years, 4 months ago (2014-08-20 03:31:13 UTC) #11

xiyuan

6 years, 3 months ago (2014-08-31 08:41:01 UTC) #12

Message was sent while issue was closed.

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/521343002/ by xiyuan@chromium.org.

The reason for reverting is: No longer needed since underlying blink issue
http://crbug.com/405250 is fixed..

Expand Messages | Collapse Messages