Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 487333002: Get rid of last non-storeic use of JSReceiver::Lookup (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of last non-storeic use of JSReceiver::Lookup BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23211

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M src/ast.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 7 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-19 16:17:35 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-08-19 16:30:37 UTC) #2
Jakob Kummerow
On 2014/08/19 16:30:37, Jakob wrote: > lgtm That was for patch set 1. Holding off ...
6 years, 4 months ago (2014-08-19 16:34:00 UTC) #3
Jakob Kummerow
Patch set 3 LGTM.
6 years, 4 months ago (2014-08-19 16:54:12 UTC) #4
Toon Verwaest
6 years, 4 months ago (2014-08-19 17:04:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 23211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698