Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 48733008: Factor out Sec-WebSocket-Accept computing logic so that the new WebSocket handshake processor can r… (Closed)

Created:
7 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 1 month ago
Reviewers:
Adam Rice
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Factor out Sec-WebSocket-Accept computing logic so that the new WebSocket handshake processor can reuse it. BUG=226931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M net/websockets/websocket_handshake_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 1 month ago (2013-10-29 06:13:51 UTC) #1
Adam Rice
lgtm
7 years, 1 month ago (2013-10-29 08:48:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/48733008/1
7 years, 1 month ago (2013-10-29 09:04:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=94266
7 years, 1 month ago (2013-10-29 12:05:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/48733008/1
7 years, 1 month ago (2013-10-29 15:45:53 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 01:37:30 UTC) #6
Message was sent while issue was closed.
Change committed as 231707

Powered by Google App Engine
This is Rietveld 408576698