Issue 48733005: Fix regression introduced with r159483. The RenderScrollbar's parent class had the signature of a …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48733005: Fix regression introduced with r159483. The RenderScrollbar's parent class had the signature of a … (Closed)

Created:
7 years, 1 month ago by atreat

Modified:
7 years, 1 month ago

Reviewers:
lgombos, Nico, Inactive

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

Fix regression introduced with r159483. The RenderScrollbar's parent class had the signature of a virtual changed out from under it. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160742

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/rendering/RenderScrollbar.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/RenderScrollbar.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

atreat

Fixes a regression introduced here: https://codereview.chromium.org/26936002

7 years, 1 month ago (2013-10-28 18:50:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/48733005/1

7 years, 1 month ago (2013-10-28 18:54:40 UTC) #4

Message was sent while issue was closed.

Change committed as 160742