Issue 48733003: android: Add support for html-packaged trace files to adb_profile_chrome

Issue 48733003: android: Add support for html-packaged trace files to adb_profile_chrome (Closed)

Created:
7 years, 1 month ago by Sami

Modified:
7 years, 1 month ago

Reviewers:
bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, nduca

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Add support for html-packaged trace files to adb_profile_chrome Add support for html-packaged trace files to adb_profile_chrome. The --html option will cause the trace file to be serialized into an html file that contains a snapshot of the Trace Viewer from the Chromium source tree. The resulting file has no other dependencies and therefore does not require a specific version of Chrome for viewing. This patch also adds the --view option for automatically opening the written trace file in a browser. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231333

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/'''/"""/g #

Patch Set 3 : vi fail. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -8 lines)			Patch
	M	build/android/adb_profile_chrome.py	View	1 2	9 chunks	+90 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! tiny nit: https://codereview.chromium.org/48733003/diff/1/build/android/adb_profile_chrome.py File build/android/adb_profile_chrome.py (right): https://codereview.chromium.org/48733003/diff/1/build/android/adb_profile_chrome.py#newcode27 build/android/adb_profile_chrome.py:27: _TRACE_VIEWER_TEMPLATE = '''<!DOCTYPE html> nit: ...

7 years, 1 month ago (2013-10-28 14:58:50 UTC) #2

Sami

Thanks! https://codereview.chromium.org/48733003/diff/1/build/android/adb_profile_chrome.py File build/android/adb_profile_chrome.py (right): https://codereview.chromium.org/48733003/diff/1/build/android/adb_profile_chrome.py#newcode27 build/android/adb_profile_chrome.py:27: _TRACE_VIEWER_TEMPLATE = '''<!DOCTYPE html> On 2013/10/28 14:58:50, bulach ...

7 years, 1 month ago (2013-10-28 15:36:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/48733003/50001

7 years, 1 month ago (2013-10-28 15:36:50 UTC) #4

commit-bot: I haz the power

Commit queue failed due to new patchset.

7 years, 1 month ago (2013-10-28 15:38:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/48733003/90001

7 years, 1 month ago (2013-10-28 15:38:27 UTC) #6

Message was sent while issue was closed.

Change committed as 231333

Expand Messages | Collapse Messages