sdk/lib/async/broadcast_stream_controller.dart - Issue 48733002: Fix bugs in StreamController.addStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/broadcast_stream_controller.dart

Issue 48733002: Fix bugs in StreamController.addStream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove StreamControllerSink. The optional cancelOnError on addStream is only in controller. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/async/broadcast_stream_controller.dart

diff --git a/sdk/lib/async/broadcast_stream_controller.dart b/sdk/lib/async/broadcast_stream_controller.dart

index 2e4366928a46f65e5938fa24fbe33093ee0ad64e..28c4ef827cc2d42a9eb4e692148b0f6ce33f932a 100644

--- a/sdk/lib/async/broadcast_stream_controller.dart

+++ b/sdk/lib/async/broadcast_stream_controller.dart

@@ -238,10 +238,10 @@ abstract class _BroadcastStreamController<T>

Future get done => _ensureDoneFuture();

- Future addStream(Stream<T> stream) {

+ Future addStream(Stream<T> stream, {bool cancelOnError: true}) {

if (!_mayAddEvent) throw _addEventError();

_state |= _STATE_ADDSTREAM;

- _addStreamState = new _AddStreamState(this, stream);

+ _addStreamState = new _AddStreamState(this, stream, cancelOnError);

return _addStreamState.addStreamFuture;

}