Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 487273004: Make InfobarContainer scrollable. (Closed)

Created:
6 years, 4 months ago by newt (away)
Modified:
6 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make InfobarContainer scrollable. If only this were simple. BUG=393999 CQ_TRYBOTS=tryserver.chromium.linux:android_aosp,android_clang_dbg,android_dbg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291275

Patch Set 1 #

Patch Set 2 : removed custom drawChild logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -56 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java View 6 chunks +10 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 12 chunks +86 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
PTAL
6 years, 4 months ago (2014-08-21 17:58:58 UTC) #1
newt (away)
PTAL
6 years, 4 months ago (2014-08-21 20:48:18 UTC) #2
gone
lgtm
6 years, 4 months ago (2014-08-21 21:03:19 UTC) #3
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 4 months ago (2014-08-21 21:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/487273004/20001
6 years, 4 months ago (2014-08-21 21:13:08 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 00:41:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291275

Powered by Google App Engine
This is Rietveld 408576698