Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 487223003: Remove package_name from java_apk.gypi (Closed)

Created:
6 years, 4 months ago by hjd
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, haitaol+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove package_name from java_apk.gypi This change completes the removal of package_name from build/java_apk.gyp and removes it from all the places which still refer to it. 'package_name' used to be how you specified the intermediate directory when building an APK. Now we use the target name and includers no longer need to set the intermediate directory explicitly. However one use in java_apk for setting additional resources files seems to have crept through the refactoring. BUG=405963 Committed: https://crrev.com/a1ee8d91945a17948026ef18dce2a2121db7fbd5 Cr-Commit-Position: refs/heads/master@{#293498}

Patch Set 1 #

Patch Set 2 : Put some of chrome package_name back #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/android/tests/multiple_proguards/multiple_proguards.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sync/sync_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/memconsumer/memconsumer.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
hjd
Could you ptal at build/java_apk.gypi? If you think it's a good idea I'll round up ...
6 years, 3 months ago (2014-09-03 11:00:35 UTC) #2
cjhopman
lgtm
6 years, 3 months ago (2014-09-03 17:47:29 UTC) #3
hjd
maniscalco@ could you do a OWNERS review of sync/sync_tests.gypi? Thanks!
6 years, 3 months ago (2014-09-04 08:39:24 UTC) #5
maniscalco
On 2014/09/04 08:39:24, hjd wrote: > maniscalco@ could you do a OWNERS review of sync/sync_tests.gypi? ...
6 years, 3 months ago (2014-09-04 16:06:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hjd@chromium.org/487223003/40001
6 years, 3 months ago (2014-09-05 09:41:16 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bb1c7b6e9c085bb30f978ac976066f398c34fc92
6 years, 3 months ago (2014-09-05 10:44:24 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:45 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a1ee8d91945a17948026ef18dce2a2121db7fbd5
Cr-Commit-Position: refs/heads/master@{#293498}

Powered by Google App Engine
This is Rietveld 408576698