chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h - Issue 487193003: Update Mac password generation autofill popup to match latest mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

Issue 487193003: Update Mac password generation autofill popup to match latest mocks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.mm ('K') | « chrome/browser/ui/cocoa/autofill/password_generation_popup_view_bridge.mm ('k') | chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm » ('j') | chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

diff --git a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

index e475161c8796473ab29d438de8821feaac08d736..f1e8d21b79f0e5af42e1d6a279d36cbef9eef455 100644

--- a/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

+++ b/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.h

@@ -24,7 +24,8 @@ class AutofillPopupController;

__weak autofill::PasswordGenerationPopupController* controller_;

__weak NSTextField* passwordField_;

- __weak NSTextField* passwordSubtextField_;

+ __weak NSTextField* passwordTitleField_;

+ __weak NSImage* keyIcon_;

__weak HyperlinkTextView* helpTextView_;

}

@@ -33,10 +34,15 @@ class AutofillPopupController;

(autofill::PasswordGenerationPopupController*)controller

frame:(NSRect)frame;

+- (BOOL)isPointInPasswordBounds:(CGPoint)point;

Ilya Sherman 2014/08/19 22:32:17 nit: Can the |point| be passed as an NSPoint rathe

Ilya Sherman 2014/08/19 22:32:17 Please add documentation for this method.

dconnelly 2014/08/20 17:07:05 Done.

// Informs the view that its controller has been (or will imminently be)

// destroyed.

- (void)controllerDestroyed;

+// The preferred size for the popup.

+- (NSSize)preferredSize;

@end

#endif // CHROME_BROWSER_UI_COCOA_AUTOFILL_PASSWORD_GENERATION_POPUP_VIEW_COCOA_H_