Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 487163004: [turbofan] Add ARM64 tests and fix shift bug (Closed)

Created:
6 years, 4 months ago by m.m.capewell
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add ARM64 tests and fix shift bug Add more tests for logical immediate and shift instruction selection, and fix bug in range for supported shifts. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 4 chunks +107 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
6 years, 4 months ago (2014-08-19 17:35:35 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-20 04:18:46 UTC) #2
m.m.capewell
6 years, 4 months ago (2014-08-20 09:25:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698