[sync] Allow FakeURLFetcher to return arbitrary HTTP response codes

chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h"
 
 #include "base/compiler_specific.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_utils.h"
+#include "net/http/http_status_code.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_fetcher.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/size.h"
 #include "ui/gfx/skia_util.h"
 
 namespace {
 const bool kAsyncCall = true;
@@ skipping 75 matching lines @@
   ASSERT_TRUE(gfx::PNGCodec::EncodeBGRASkBitmap(image, true, &compressed));
 
   // Copy the bits into the string, and put them into the FakeURLFetcher.
   std::string image_string(compressed.begin(), compressed.end());
 
   // Set up a delegate to wait for the callback.
   NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
 
   NotificationBitmapFetcher fetcher(url, &delegate);
 
-  url_fetcher_factory_->SetFakeResponse(url, image_string, true);
+  url_fetcher_factory_->SetFakeResponse(url, image_string, net::HTTP_OK);
 
   // We expect that the image decoder will get called and return
   // an image in a callback to OnImageDecoded().
   fetcher.Start(browser()->profile());
 
   // Blocks until test delegate is notified via a callback.
   content::RunMessageLoop();
 
   ASSERT_TRUE(delegate.success());
 
@@ skipping 29 matching lines @@
                        OnURLFetchFailureTest) {
   GURL url("http://example.com/this-should-be-fetch-failure");
 
   // We intentionally put no data into the bitmap to simulate a failure.
 
   // Set up a delegate to wait for the callback.
   NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
 
   NotificationBitmapFetcher fetcher(url, &delegate);
 
-  url_fetcher_factory_->SetFakeResponse(url, std::string(), false);
+  url_fetcher_factory_->SetFakeResponse(url,
+                                        std::string(),
+                                        net::HTTP_INTERNAL_SERVER_ERROR);
 
   fetcher.Start(browser()->profile());
 
   // Blocks until test delegate is notified via a callback.
   content::RunMessageLoop();
 
   EXPECT_FALSE(delegate.success());
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,
                        HandleImageFailedTest) {
   GURL url("http://example.com/this-should-be-a-decode-failure");
   NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
   NotificationBitmapFetcher fetcher(url, &delegate);
   url_fetcher_factory_->SetFakeResponse(
-      url, std::string("Not a real bitmap"), true);
+      url, std::string("Not a real bitmap"), net::HTTP_OK);
 
   fetcher.Start(browser()->profile());
 
   // Blocks until test delegate is notified via a callback.
   content::RunMessageLoop();
 
   EXPECT_FALSE(delegate.success());
 }
 
 }  // namespace notifier