Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 48713005: Added test to check that GPU features are listed as hardware accelerated. (Closed)

Created:
7 years, 1 month ago by bajones
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org
Visibility:
Public.

Description

Added test to check that GPU features are listed as hardware accelerated. BUG=312395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231497

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 1 chunk +69 lines, -0 lines 0 comments Download
A content/test/gpu/gpu_tests/hardware_accelerated_feature_expectations.py View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bajones
Needs the updates to expectations from https://codereview.chromium.org/49353004/ before this can land. Covers functionality previously tested ...
7 years, 1 month ago (2013-10-28 20:18:15 UTC) #1
Ken Russell (switch to Gerrit)
LGTM with the following issues addressed. https://codereview.chromium.org/48713005/diff/1/content/test/gpu/gpu_tests/accelerated.py File content/test/gpu/gpu_tests/accelerated.py (right): https://codereview.chromium.org/48713005/diff/1/content/test/gpu/gpu_tests/accelerated.py#newcode39 content/test/gpu/gpu_tests/accelerated.py:39: class Accelerated(test.Test): Please ...
7 years, 1 month ago (2013-10-28 20:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/48713005/60001
7 years, 1 month ago (2013-10-28 23:43:41 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 03:01:36 UTC) #4
Message was sent while issue was closed.
Change committed as 231497

Powered by Google App Engine
This is Rietveld 408576698