Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 486933002: EasyUnlockCryptoDelegateChromeOS should not own EasyUnlockClient (Closed)

Created:
6 years, 4 months ago by tbarzic
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

EasyUnlockCryptoDelegateChromeOS should not own EasyUnlockClient The client is used by dbus client bundle. BUG=404798 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tbarzic
6 years, 4 months ago (2014-08-18 21:39:42 UTC) #1
xiyuan
lgtm
6 years, 4 months ago (2014-08-18 22:03:28 UTC) #2
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 4 months ago (2014-08-18 22:39:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/486933002/1
6 years, 4 months ago (2014-08-18 22:40:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-19 00:00:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 00:05:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290417

Powered by Google App Engine
This is Rietveld 408576698