dart/tests/standalone/io/http_cross_process_test.dart - Issue 486853005: Fix idle connection pool issue in dart:io's HttpClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tests/standalone/io/http_cross_process_test.dart

Issue 486853005: Fix idle connection pool issue in dart:io's HttpClient (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed existing tests, removed bogus test, use async_helper for new test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/tests/standalone/io/http_cross_process_test.dart

diff --git a/dart/tests/standalone/io/http_cross_process_test.dart b/dart/tests/standalone/io/http_cross_process_test.dart

index 1b24c9558c3756dab7fc81b7a13b3ab19c870637..b16763dee9fcda98e63d26aefc3fa4208ba1ff25 100644

--- a/dart/tests/standalone/io/http_cross_process_test.dart

+++ b/dart/tests/standalone/io/http_cross_process_test.dart

@@ -54,6 +54,7 @@ runClient(int port) {

var client = new HttpClient();

client.get('127.0.0.1', port, "/")

.then((request) => request.close())

- .then((response) => response.listen((data) {},

- onDone: () => print('SUCCESS')));

+ .then((response) => response.drain())

+ .then((_) => client.close())

+ .then((_) => print('SUCCESS'));

}