Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 486853004: test262.status: ES6 tests pass when harmony

Created:
6 years, 4 months ago by smikes
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
git@github.com:smikes/v8.git@master
Project:
v8
Visibility:
Public.

Description

test262.status: ES6 tests pass when harmony use new context variable 'harmony' to describe ES6 tests as passing when 'harmony' is set, failing otherwise test262/testcfg.py: support context.harmony add --harmony flag when context.harmony is True run-tests.py: add support for --harmony in context run-tests.py: - add support for --harmony - add 'harmony' to variables objects/context.py: - serialize and deserialize harmony BUG=v8:3521

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -12 lines) Patch
M test/test262/harness-adapt.js View 1 chunk +9 lines, -0 lines 1 comment Download
M test/test262/test262.status View 1 chunk +56 lines, -0 lines 0 comments Download
M test/test262/testcfg.py View 2 chunks +47 lines, -8 lines 0 comments Download
M tools/run-tests.py View 3 chunks +5 lines, -1 line 0 comments Download
M tools/testrunner/objects/context.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
smikes
Patch to implement 'harmony' in context for test runners. Unfortunately this changeset includes the entire ...
6 years, 4 months ago (2014-08-19 03:20:55 UTC) #1
Jakob Kummerow
I don't think we need this. The harmony-related tests will start passing when the respective ...
6 years, 4 months ago (2014-08-19 09:49:40 UTC) #2
smikes
6 years, 4 months ago (2014-08-19 12:37:46 UTC) #3
On 2014/08/19 09:49:40, Jakob wrote:
> I don't think we need this. The harmony-related tests will start passing when
> the respective features are enabled by default, which IMHO is good enough.

Fair enough.  I'll leave it here, and when harmony features start landing
 (or more tests start covering harmony), if you decide you want it, here it is.

Powered by Google App Engine
This is Rietveld 408576698