cc/resources/video_resource_updater.cc - Issue 486853002: cc: Use a normal texture for background texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 486853002: cc: Use a normal texture for background texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TextureHintImmutableFramebuffer because fbo binding immutable texture is efficient. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index d113e8bf5d5196527433f7b65964e6c52454bd0c..6e4dcd933b9cbe9774b3df6f918194cec3b8e09f 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -193,11 +193,11 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(

if (resource_id == 0) {

// TODO(danakj): Abstract out hw/sw resource create/delete from

// ResourceProvider and stop using ResourceProvider in this class.

- resource_id =

- resource_provider_->CreateResource(output_plane_resource_size,

- GL_CLAMP_TO_EDGE,

- ResourceProvider::TextureUsageAny,

- output_resource_format);

+ resource_id = resource_provider_->CreateResource(

+ output_plane_resource_size,

+ GL_CLAMP_TO_EDGE,

+ ResourceProvider::TextureHintImmutable,

+ output_resource_format);

DCHECK(mailbox.IsZero());