Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: src/promise.js

Issue 486763002: Make all global private symbols own symbols. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/macros.py ('K') | « src/macros.py ('k') | src/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/promise.js
diff --git a/src/promise.js b/src/promise.js
index 9e88aa56ce042a5e90c49adf65d7e832fe30b10b..b6e03d77f6d0f91c38b71f78cb6cfbf6f7c8c01d 100644
--- a/src/promise.js
+++ b/src/promise.js
@@ -25,12 +25,12 @@ var PromiseHasRejectHandler;
// TODO(jkummerow/rossberg/yangguo): Find a better solution.
// Status values: 0 = pending, +1 = resolved, -1 = rejected
-var promiseStatus = GLOBAL_PRIVATE("Promise#status");
-var promiseValue = GLOBAL_PRIVATE("Promise#value");
-var promiseOnResolve = GLOBAL_PRIVATE("Promise#onResolve");
-var promiseOnReject = GLOBAL_PRIVATE("Promise#onReject");
-var promiseRaw = GLOBAL_PRIVATE("Promise#raw");
-var promiseDebug = GLOBAL_PRIVATE("Promise#debug");
+var promiseStatus = GLOBAL_PRIVATE_OWN("Promise#status");
+var promiseValue = GLOBAL_PRIVATE_OWN("Promise#value");
+var promiseOnResolve = GLOBAL_PRIVATE_OWN("Promise#onResolve");
+var promiseOnReject = GLOBAL_PRIVATE_OWN("Promise#onReject");
+var promiseRaw = GLOBAL_PRIVATE_OWN("Promise#raw");
+var promiseDebug = GLOBAL_PRIVATE_OWN("Promise#debug");
var lastMicrotaskId = 0;
(function() {
@@ -146,7 +146,7 @@ var lastMicrotaskId = 0;
// For bootstrapper.
IsPromise = function IsPromise(x) {
- return IS_SPEC_OBJECT(x) && HAS_PRIVATE(x, promiseStatus);
+ return IS_SPEC_OBJECT(x) && !IS_PRIVATE_OWN_UNDEFINED(x, promiseStatus);
}
PromiseCreate = function PromiseCreate() {
@@ -162,7 +162,7 @@ var lastMicrotaskId = 0;
// Check promiseDebug property to avoid duplicate event.
if (DEBUG_IS_ACTIVE &&
GET_PRIVATE(promise, promiseStatus) == 0 &&
- !HAS_PRIVATE(promise, promiseDebug)) {
+ IS_PRIVATE_OWN_UNDEFINED(promise, promiseDebug)) {
%DebugPromiseRejectEvent(promise, r);
}
PromiseDone(promise, -1, r, promiseOnReject)
« src/macros.py ('K') | « src/macros.py ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698