src/macros.py - Issue 486763002: Make all global private symbols own symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/macros.py

Issue 486763002: Make all global private symbols own symbols. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/macros.py

diff --git a/src/macros.py b/src/macros.py

index 131df878b5d8716db6dca81ad3710610f37cfc56..817430f17f6dccf4fabca7e73f2c2d769abe6f92 100644

--- a/src/macros.py

+++ b/src/macros.py

@@ -170,10 +170,11 @@ macro JSON_NUMBER_TO_STRING(arg) = ((%_IsSmi(%IS_VAR(arg)) || arg - arg == 0) ?

# Private names.

# GET_PRIVATE should only be used if the property is known to exists on obj

# itself (it should really use %GetOwnProperty, but that would be way slower).

-macro GLOBAL_PRIVATE(name) = (%CreateGlobalPrivateSymbol(name));

+macro GLOBAL_PRIVATE_OWN(name) = (%CreateGlobalPrivateOwnSymbol(name));

macro NEW_PRIVATE(name) = (%CreatePrivateSymbol(name));

macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));

macro HAS_PRIVATE(obj, sym) = (%HasOwnProperty(obj, sym));

+macro IS_PRIVATE_OWN_UNDEFINED(obj, sym) = (IS_UNDEFINED(obj[sym]));

rossberg 2014/08/19 12:04:31 How about HAS_DEFINED_PRIVATE, for more consistenc

Dmitry Lomov (no reviews) 2014/08/19 13:29:56 Done.

macro GET_PRIVATE(obj, sym) = (obj[sym]);

macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val);

macro DELETE_PRIVATE(obj, sym) = (delete obj[sym]);

« no previous file with comments | « src/array-iterator.js ('k') | src/promise.js » ('j') | no next file with comments »