Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 486703002: Revert of XMLHttpRequest::overrideMimeType should throw InvalidStateError (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Revert of XMLHttpRequest::overrideMimeType should throw InvalidStateError (patchset #4 of https://codereview.chromium.org/478223002/) Reason for revert: It looks like this broke a number of Chromium-side browser tests: See http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3608 for example. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&testType=browser_tests&tests=ExtensionBrowserTest.RSSParseFeedInvalidFeed1,ExtensionBrowserTest.RSSParseFeedInvalidFeed2,ExtensionBrowserTest.RSSParseFeedInvalidFeed3,ExtensionBrowserTest.RSSParseFeedInvalidFeed4,ExtensionBrowserTest.RSSParseFeedValidFeed0,ExtensionBrowserTest.RSSParseFeedValidFeed2,ExtensionBrowserTest.RSSParseFeedValidFeed3,ExtensionBrowserTest.RSSParseFeedValidFeed4,ExtensionBrowserTest.RSSParseFeedValidFeed5,ExtensionBrowserTest.RSSParseFeedValidFeed6,ExtensionBrowserTest.RSSParseFeedValidFeedNoLinks for all the broken tests. Original issue's description: > XMLHttpRequest::overrideMimeType should throw InvalidStateError > > Before this CL, XMLHttpRequest accepted |overrideMimeType| regardless > of its state. This is not conformant to the current spec: > http://www.w3.org/TR/XMLHttpRequest2/#the-overridemimetype-method > > This CL changes it to throw InvalidStateError when the state > is LOADING or DONE, which aligns to the spec. > > BUG=402375 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180440 TBR=tyoshino@chromium.org,abarth@chromium.org,haraken@chromium.org,kouhei@chromium.org NOTREECHECKS=true NOTRY=true BUG=402375 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -58 lines) Patch
D LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-allowedState.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-allowedState-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Created Revert of XMLHttpRequest::overrideMimeType should throw InvalidStateError
6 years, 4 months ago (2014-08-18 13:12:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/486703002/1
6 years, 4 months ago (2014-08-18 13:12:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 180455
6 years, 4 months ago (2014-08-18 13:13:32 UTC) #3
haraken
LGTM, thanks for the revert.
6 years, 4 months ago (2014-08-18 13:17:15 UTC) #4
kouhei (in TOK)
6 years, 4 months ago (2014-08-18 23:06:52 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698