Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 486633002: DevTools: [SSP] Do not re-show color popover after going full-screen (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
Reviewers:
eustas, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] Do not re-show color popover after going full-screen R=eustas, lushnikov BUG=404555 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/devtools/front_end/elements/Spectrum.js View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
apavlov
6 years, 4 months ago (2014-08-18 11:22:08 UTC) #1
lushnikov
lgtm
6 years, 4 months ago (2014-08-18 11:40:23 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-18 11:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/486633002/1
6 years, 4 months ago (2014-08-18 11:42:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 12:56:17 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 13:29:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180456

Powered by Google App Engine
This is Rietveld 408576698