Fix more warnings in wtf

Fix more warnings in wtf. These has been observed with clang on mac.

BUG=312287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161276

[lgombos, 2013-10-31 20:54:11]

cevans@chromium.org: Can you please review changes in PartitionAlloc.cpp .

I plan to land this and than follow up with
https://codereview.chromium.org/51413003/ .

[Nico, 2013-10-31 21:03:40]

Everything except PartitionAlloc.cpp lgtm. PartitionAlloc.cpp does some tricky
things with negative numbers, so cevans should look and confirm that just
static_cast is the right thing to do there.

https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp
File Source/wtf/dtoa.cpp (right):

https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp#newco...
Source/wtf/dtoa.cpp:607: #define Scale_Bit 0x10
Scale_Bit can go too, right?

[lgombos, 2013-10-31 21:07:08]

https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp
File Source/wtf/dtoa.cpp (right):

https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp#newco...
Source/wtf/dtoa.cpp:607: #define Scale_Bit 0x10
On 2013/10/31 21:03:40, Nico wrote:
> Scale_Bit can go too, right?

Yep, indeed, but it does not seems to cause me any warnings or errors. Do you
see any ?

This is imported/third party code and not sure what's the policy for this.
Perhaps we should change it as little as possible ?

Just let me know if you prefer to remove it as well.

[Nico, 2013-10-31 21:17:41]

On Thu, Oct 31, 2013 at 2:07 PM, <l.gombos@samsung.com> wrote:

>
> https://codereview.chromium.**org/48663004/diff/30001/**
>
Source/wtf/dtoa.cpp<https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp>
> File Source/wtf/dtoa.cpp (right):
>
> https://codereview.chromium.**org/48663004/diff/30001/**
>
Source/wtf/dtoa.cpp#newcode607<https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp#newcode607>
> Source/wtf/dtoa.cpp:607: #define Scale_Bit 0x10
> On 2013/10/31 21:03:40, Nico wrote:
>
>> Scale_Bit can go too, right?
>>
>
> Yep, indeed, but it does not seems to cause me any warnings or errors.
> Do you see any ?
>

No. It's just a define, compilers don't complain about unused defines as
far as I know.


> This is imported/third party code and not sure what's the policy for
> this. Perhaps we should change it as little as possible ?
>
> Just let me know if you prefer to remove it as well.
>

Since you're touching that area anyhow, I'd probably remove it. But as is
is fine too.


>
>
https://codereview.chromium.**org/48663004/<https://codereview.chromium.org/4...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[lgombos, 2013-11-04 14:45:39]

On 2013/10/31 21:03:40, Nico wrote:
> Everything except PartitionAlloc.cpp lgtm. PartitionAlloc.cpp does some tricky
> things with negative numbers, so cevans should look and confirm that just
> static_cast is the right thing to do there.
> 
> https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp
> File Source/wtf/dtoa.cpp (right):
> 
>
https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp#newco...
> Source/wtf/dtoa.cpp:607: #define Scale_Bit 0x10

Chris, can you help us and take a look at the change in PartitionAlloc.cpp.
Thanks.

[Chris Evans, 2013-11-04 19:49:43]

On 2013/11/04 14:45:39, lgombos wrote:
> On 2013/10/31 21:03:40, Nico wrote:
> > Everything except PartitionAlloc.cpp lgtm. PartitionAlloc.cpp does some
tricky
> > things with negative numbers, so cevans should look and confirm that just
> > static_cast is the right thing to do there.
> > 
> > https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp
> > File Source/wtf/dtoa.cpp (right):
> > 
> >
>
https://codereview.chromium.org/48663004/diff/30001/Source/wtf/dtoa.cpp#newco...
> > Source/wtf/dtoa.cpp:607: #define Scale_Bit 0x10
> 
> Chris, can you help us and take a look at the change in PartitionAlloc.cpp.
> Thanks.

LGTM

[commit-bot: I haz the power, 2013-11-04 19:53:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/48663004/30001

[commit-bot: I haz the power, 2013-11-04 20:40:11]

Change committed as 161276