Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 486603002: Fix the unnecessary sleep when no back to back OnData call. (Closed)

Created:
6 years, 4 months ago by no longer working on chromium
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix the unnecessary sleep when no back to back OnData call. The sleep is required by Pepper Flash input to avoid back to back OnData() call, which will override the previous buffer if it happens. This CL is a follow up to https://codereview.chromium.org/465313002/ BUG=403675 TEST=bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/audio/pulse/pulse_input.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
no longer working on chromium
Henrik, could you please review this small CL.
6 years, 4 months ago (2014-08-18 09:38:20 UTC) #1
henrika (OOO until Aug 14)
LGTM. Could you also add a short description in this CL explaining why Sleep is ...
6 years, 4 months ago (2014-08-18 10:06:43 UTC) #2
no longer working on chromium
On 2014/08/18 10:06:43, henrika wrote: > LGTM. > > Could you also add a short ...
6 years, 4 months ago (2014-08-18 10:08:43 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 4 months ago (2014-08-18 10:08:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/486603002/1
6 years, 4 months ago (2014-08-18 10:08:58 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 12:43:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290243

Powered by Google App Engine
This is Rietveld 408576698