Issue 486583002: Regression: r170111 Tapping listbox items should fire change/input event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 486583002: Regression: r170111 Tapping listbox items should fire change/input event (Closed)

Created:
6 years, 4 months ago by keishi

Modified:
6 years, 4 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Regression: r170111 Tapping listbox items should fire change/input event BUG=403184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180436

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -4 lines)			Patch
A	LayoutTests/fast/forms/select/listbox-tap-input-change-event.html	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/select/listbox-tap-input-change-event-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

keishi

mouse clicks fire change event inside HTMLSelectElement::handleMouseRelease. I forgot to call listBoxOnChange for tap.

6 years, 4 months ago (2014-08-18 08:11:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/486583002/1

6 years, 4 months ago (2014-08-18 08:15:57 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...

6 years, 4 months ago (2014-08-18 09:21:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180436