Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 486573003: DevTools: remove eye dropper from behind experiment. (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove eye dropper from behind experiment. BUG=404375 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M Source/devtools/front_end/common/Settings.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
6 years, 4 months ago (2014-08-18 11:50:06 UTC) #1
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-18 11:50:32 UTC) #2
vsevik
lgtm
6 years, 4 months ago (2014-08-18 11:50:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/486573003/1
6 years, 4 months ago (2014-08-18 11:51:28 UTC) #4
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-18 12:42:54 UTC) #5
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 4 months ago (2014-08-18 15:29:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/486573003/1
6 years, 4 months ago (2014-08-18 15:29:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 15:30:11 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/elements/Spectrum.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-18 15:30:14 UTC) #9
pfeldman
6 years, 4 months ago (2014-08-18 15:34:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as 180468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698