Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 486543002: [Drive] Handle error cases earlier in FakeDriveService (Closed)

Created:
6 years, 4 months ago by tzik
Modified:
6 years, 4 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Drive] Handle error cases earlier in FakeDriveService BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290238

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -178 lines) Patch
M chrome/browser/drive/fake_drive_service.cc View 1 2 9 chunks +200 lines, -178 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
6 years, 4 months ago (2014-08-18 02:27:57 UTC) #1
hashimoto
lgtm
6 years, 4 months ago (2014-08-18 05:02:33 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-18 05:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/486543002/40001
6 years, 4 months ago (2014-08-18 05:23:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 07:12:02 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 12:33:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 290238

Powered by Google App Engine
This is Rietveld 408576698