LayoutTests/compositing/overlap-map-stack-crash.html - Issue 486493002: Merge AcceleratedCompositingForOverflowScroll into PreferCompositingToLCDText.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/compositing/overlap-map-stack-crash.html

Issue 486493002: Merge AcceleratedCompositingForOverflowScroll into PreferCompositingToLCDText. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rm-overflowscroll: imagefailure Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/compositing/overflow/updating-scrolling-content.html ('k') | LayoutTests/compositing/rtl/rtl-overflow-scrolling.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4	4

5 <style>	5 <style>

6 #container {	6 #container {

7 position: absolute;	7 position: absolute;

8 z-index: 0;	8 z-index: 0;

9 top: 50px;	9 top: 50px;

10 left: 50px;	10 left: 50px;

(...skipping 26 matching lines...) Expand all Loading...
37 }	37 }

38	38

39 #explanation {	39 #explanation {

40 position: absolute;	40 position: absolute;

41 top: 400px;	41 top: 400px;

42 }	42 }

43 </style>	43 </style>

44	44

45 <script>	45 <script>

46 if (window.internals) {	46 if (window.internals) {

47 window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled( true);	47 window.internals.settings.setPreferCompositingToLCDTextEnabled(true);

48 }	48 }

49	49

50 function doTest() {	50 function doTest() {

51 if (!window.internals)	51 if (!window.internals)

52 document.getElementById("explanation").style.display = "block";	52 document.getElementById("explanation").style.display = "block";

53	53

54 if (window.testRunner)	54 if (window.testRunner)

55 testRunner.dumpAsText();	55 testRunner.dumpAsText();

56 }	56 }

57	57

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92	92

93 - The problem, however, is that we never created an overlap context for	93 - The problem, however, is that we never created an overlap context for

94 these negative z-index non-composited layers. When the layers try to add	94 these negative z-index non-composited layers. When the layers try to add

95 themselves to the overlap, they try to access below the bottom of the	95 themselves to the overlap, they try to access below the bottom of the

96 stack, and crash.	96 stack, and crash.

97 </pre>	97 </pre>

98	98

99 </body>	99 </body>

100	100

101 </html>	101 </html>

OLD	NEW