Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 486383003: WakeLock API: IPC at renderer side.

Created:
6 years, 4 months ago by redchenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

WakeLock API: IPC at renderer side. BUG=257511

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -1 line) Patch
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 1 comment Download
M content/renderer/render_view_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
A content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/renderer/wake_lock/wake_lock_dispatcher.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A content/renderer/wake_lock/wake_lock_dispatcher_unittest.cc View 1 chunk +180 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-03 13:23:56 UTC) #1
I think you should implement that as part of RenderFrame instead of RenderView.
Unless you have a good reason to use RenderView?

https://codereview.chromium.org/486383003/diff/1/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/486383003/diff/1/content/content_tests.gypi#n...
content/content_tests.gypi:721:
'renderer/wake_lock/wake_lock_dispatcher_unittest.cc',       
'test/fileapi_test_file_set.cc',
nit: seems like you forgot a line break here

Powered by Google App Engine
This is Rietveld 408576698