Source/bindings/scripts/code_generator_v8.pm - Issue 48633006: Teach V8GCController how to traverse TemplateContentDocumentFragment::host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 48633006: Teach V8GCController how to traverse TemplateContentDocumentFragment::host (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.pm

diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm

index a2e9487f5c9fc10204b80042bf0c68c432284beb..2d79d2255f2d7da0f75f1aaad4277d356758446a 100644

--- a/Source/bindings/scripts/code_generator_v8.pm

+++ b/Source/bindings/scripts/code_generator_v8.pm

@@ -1702,8 +1702,6 @@ sub ShouldKeepAttributeAlive

my ($interface, $attribute, $returnType) = @_;

my $attrName = $attribute->name;

- return 1 if $attribute->extendedAttributes->{"KeepAttributeAliveForGC"};

# For readonly attributes (including Replaceable), as a general rule, for

# performance reasons we keep the attribute wrapper alive while the owner

# wrapper is alive, because the attribute never changes.