Teach V8GCController how to traverse TemplateContentDocumentFragment::host

Source/bindings/v8/V8GCController.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 #include "V8MessagePort.h"
 #include "V8MutationObserver.h"
 #include "V8Node.h"
 #include "V8ScriptRunner.h"
 #include "bindings/v8/RetainedDOMInfo.h"
 #include "bindings/v8/V8AbstractEventListener.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/WrapperTypeInfo.h"
 #include "core/dom/Attr.h"
 #include "core/dom/NodeTraversal.h"
+#include "core/dom/TemplateContentDocumentFragment.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/html/HTMLImageElement.h"
 #include "platform/TraceEvent.h"
 
 namespace WebCore {
 
 // FIXME: This should use opaque GC roots.
 static void addReferencesForNodeWithEventListeners(v8::Isolate* isolate, Node* node, const v8::Persistent<v8::Object>& wrapper)
 {
@@ skipping 22 matching lines @@
     if (node->inDocument() || (node->hasTagName(HTMLNames::imgTag) && toHTMLImageElement(node)->hasPendingActivity()))
         return &node->document();
 
     if (node->isAttributeNode()) {
         Node* ownerElement = toAttr(node)->ownerElement();
         if (!ownerElement)
             return node;
         node = ownerElement;
     }
 
-    while (Node* parent = node->parentOrShadowHostNode())
+    while (Node* parent = node->parentOrShadowHostOrTemplateHostNode())
         node = parent;
 
     return node;
 }
 
 // Regarding a minor GC algorithm for DOM nodes, see this document:
 // https://docs.google.com/a/google.com/presentation/d/1uifwVYGNYTZDoGLyCb7sXa7g49mWNMW2gaWvMN5NLk8/edit#slide=id.p
 class MinorGCWrapperVisitor : public v8::PersistentHandleVisitor {
 public:
     explicit MinorGCWrapperVisitor(v8::Isolate* isolate)
@@ skipping 84 matching lines @@
         }
         return true;
     }
 
     void gcTree(v8::Isolate* isolate, Node* startNode)
     {
         Vector<Node*, initialNodeVectorSize> newSpaceNodes;
 
         Node* node = startNode;
         while (node->parentOrShadowHostNode())
             node = node->parentOrShadowHostNode();

[haraken, 2013/10/30 00:09:53]

Don't you need to change this to parentOrShadowHostOrTemplateHostNode() as well?
Otherwise, minor gc will probably mis-collect the template host node.

[adamk, 2013/10/30 17:02:45]

Very good point, forgot about minor GC (I think there was no way to test it when
<template> first landed). Will add a test and fix the code.

 
         if (!traverseTree(node, &newSpaceNodes))
             return;
 
         // We completed the DOM tree traversal. All wrappers in the DOM tree are
         // stored in newSpaceNodes and are expected to exist in the new space of V8.
         // We report those wrappers to V8 as an object group.
         Node** nodeIterator = newSpaceNodes.begin();
         Node** const nodeIteratorEnd = newSpaceNodes.end();
         if (nodeIterator == nodeIteratorEnd)
@@ skipping 211 matching lines @@
 {
     v8::HandleScope handleScope(isolate);
     v8::Local<v8::Context> context = v8::Context::New(isolate);
     if (context.IsEmpty())
         return;
     v8::Context::Scope contextScope(context);
     V8ScriptRunner::compileAndRunInternalScript(v8String("if (gc) gc();", isolate), isolate);
 }
 
 }  // namespace WebCore