Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 48633002: Only generate breakpad symbols for build artefacts (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Only generate breakpad symbols for build artefacts Generating them for system libraries takes a long time, and they're unlikely to have symbols anyway. BUG=247431 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231321

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M components/breakpad/tools/generate_breakpad_symbols.py View 1 7 chunks +29 lines, -28 lines 0 comments Download
M content/content_shell.gypi View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-10-28 13:43:54 UTC) #1
marja
lgtm
7 years, 1 month ago (2013-10-28 14:07:23 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-10-28 14:10:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r231321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698