Issue 486313004: Mojo cpp bindings: More clear checks for array num_bytes and num_elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 486313004: Mojo cpp bindings: More clear checks for array num_bytes and num_elements. (Closed)

Created:
6 years, 4 months ago by yzshen1

Modified:
6 years, 4 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo cpp bindings: More clear checks for array num_bytes and num_elements. This CL (1) handles the case that Array<>'s element number or total size exceeds what we can represent in Mojo messages; (2) makes the validation code of the num_bytes field doesn't rely on sizeof(size_t) > sizeof(uint32_t). The newly-added test passes with/without this CL. But I think it is good to have such a test. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290718

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -21 lines)			Patch
M	mojo/public/cpp/bindings/lib/array_internal.h	View	1 2 3	7 chunks	+41 lines, -17 lines	0 comments	Download
M	mojo/public/cpp/bindings/lib/array_serialization.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	mojo/public/cpp/bindings/lib/string_serialization.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_array_num_bytes_overflow.data	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd8_array_num_bytes_overflow.expected	View		0 chunks	+-1 lines, --1 lines	0 comments	Download