Clean up dump-info and js_backend.

sdk/lib/_internal/compiler/implementation/dump_info.dart

Index: sdk/lib/_internal/compiler/implementation/dump_info.dart
diff --git a/sdk/lib/_internal/compiler/implementation/dump_info.dart b/sdk/lib/_internal/compiler/implementation/dump_info.dart
index c125f21bf2b8734df0c74d8b137a29bb497418ca..af372e0e214d928ccd5a0d445da853d85539b046 100644
--- a/sdk/lib/_internal/compiler/implementation/dump_info.dart
+++ b/sdk/lib/_internal/compiler/implementation/dump_info.dart
@@ -87,8 +87,8 @@ class ElementToJsonVisitor extends ElementVisitor<Map<String, dynamic>> {
   Duration compilationDuration;
   Duration dumpInfoDuration;
 
-  ElementToJsonVisitor(Compiler compiler) {
-    this.compiler = compiler;
+  ElementToJsonVisitor(Compiler compiler)

[sra1, 2014/08/19 22:05:25]

Or ElementToJsonVisitor(this.compiler)

[Ty Overby (Google), 2014/08/20 17:23:50]

Done.

+      :compiler = compiler {

[sigurdm, 2014/08/20 08:37:47]

Nitpicking: space after the colon.

From the style guide:
DO format constructor initialization lists with each field on its own line.
MyClass()
    : firstField = "some value",
      secondField = "another",
      thirdField = "last" {
  // ...
}

[Ty Overby (Google), 2014/08/20 17:23:50]

Acknowledged.

 
     Backend backend = compiler.backend;

[sra1, 2014/08/19 22:05:25]

Peter suggested not doing so much work in the constructor.
You could put all this code in a 'run' method and call

new ElementToJsonVisitor(compiler).run()

[Ty Overby (Google), 2014/08/20 17:23:50]

Done.

     if (backend is JavaScriptBackend) {
@@ -99,7 +99,6 @@ class ElementToJsonVisitor extends ElementVisitor<Map<String, dynamic>> {
       programSize = compiler.assembledCode.length;
     }
 
-
     compilationMoment = new DateTime.now();
     dart2jsVersion = compiler.hasBuildId ? compiler.buildId : null;
     compilationDuration = compiler.totalCompileTime.elapsed;