Clean up dump-info and js_backend.

BUG=
R=sigurdm@google.com, sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39464

[sra1, 2014-08-19 22:05:25]

DBC

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:79: Compiler compiler;
Can be 'final'.

Make other fields could be final too where appropriate

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:90:
ElementToJsonVisitor(Compiler compiler)
Or ElementToJsonVisitor(this.compiler)

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:93: Backend backend =
compiler.backend;
Peter suggested not doing so much work in the constructor.
You could put all this code in a 'run' method and call

new ElementToJsonVisitor(compiler).run()

[sigurdm, 2014-08-20 08:37:47]

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:91: :compiler =
compiler {
Nitpicking: space after the colon.

From the style guide:
DO format constructor initialization lists with each field on its own line.
MyClass()
    : firstField = "some value",
      secondField = "another",
      thirdField = "last" {
  // ...
}

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:949: //
TODO(tyoverby) send the context element to DumpInfoTask to be
another nit: 
colon after the todo, and start sentence with capital letter:
// TODO(tyoverby): Send the context element to DumpInfoTask to be

[Ty Overby (Google), 2014-08-20 17:23:51]

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:79: Compiler compiler;
On 2014/08/19 22:05:25, sra1 wrote:
> Can be 'final'.
> 
> Make other fields could be final too where appropriate

Done.

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:90:
ElementToJsonVisitor(Compiler compiler)
On 2014/08/19 22:05:25, sra1 wrote:
> Or ElementToJsonVisitor(this.compiler)

Done.

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:91: :compiler =
compiler {
On 2014/08/20 08:37:47, sigurdm wrote:
> Nitpicking: space after the colon.
> 
> From the style guide:
> DO format constructor initialization lists with each field on its own line.
> MyClass()
>     : firstField = "some value",
>       secondField = "another",
>       thirdField = "last" {
>   // ...
> }

Acknowledged.

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:93: Backend backend =
compiler.backend;
On 2014/08/19 22:05:25, sra1 wrote:
> Peter suggested not doing so much work in the constructor.
> You could put all this code in a 'run' method and call
> 
> new ElementToJsonVisitor(compiler).run()

Done.

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/486313003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:949: //
TODO(tyoverby) send the context element to DumpInfoTask to be
On 2014/08/20 08:37:47, sigurdm wrote:
> another nit: 
> colon after the todo, and start sentence with capital letter:
> // TODO(tyoverby): Send the context element to DumpInfoTask to be

Done.

[sra1, 2014-08-20 18:19:44]

lgtm

[sigurdm, 2014-08-21 06:37:44]

Oh i also forgot lgtm

[Ty Overby (Google), 2014-08-21 17:49:31]

Committed patchset #2 manually as 39464 (presubmit successful).