Contextual search - clean up histogram.xml metric definitions.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5f84acab589b5a01833a077269d67b967a632eef..07f3a19b4522756abfe52c685f59ba7a50820cb1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -28235,40 +28235,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
-<histogram name="Search.ContextualSearchOptCard"
-    enum="ContextualSearchOptCardAction">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The type of action taken in the Opt-in card.</summary>
-</histogram>
-
-<histogram name="Search.ContextualSearchOptPeekCard"

[Alexei Svitkine (slow), 2014/08/20 14:42:43]

I don't see these being added in another CL to the internal file.

Please don't delete existing histograms definitions (unless we never ever saw
any data for them - e.g. the corresponding code didn't exist or wasn't hit).

Instead, the best practice is to mark them as <obsolete> in the file.

In this case, since they're moving to the internal file, you can first move them
offer (i.e. with a corresponding google3 CL that re-adds these) and then in a
follow-up CL, annotate the ones that are obsolete as such.

-    enum="ContextualSearchPeekCardAction">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The type of action taken when the Opt-in card is peeking.</summary>
-</histogram>
-
-<histogram name="Search.ContextualSearchPeekCard"
-    enum="ContextualSearchPeekCardAction">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The type of action taken when the Search card is peeking.</summary>
-</histogram>
-
-<histogram name="Search.ContextualSearchTap" enum="ContextualSearchTapAction">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The type of tap action taken by opted-in users.</summary>
-</histogram>
-
-<histogram name="Search.ContextualSearchTapUndecided"
-    enum="ContextualSearchTapAction">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The type of tap action taken by undecided users.</summary>
-</histogram>
-
-<histogram name="Search.ContextualSearchTimeToSearch" units="milliseconds">
-  <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
-  <summary>The time between tapping on a word and performing a search.</summary>
-</histogram>
-
 <histogram name="Search.DefaultSearchChangeOrigin"
     enum="DefaultSearchChangeOrigin">
   <owner>mathp@chromium.org</owner>
@@ -38306,28 +38272,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="4" label="SESSION_ONLY"/>
 </enum>
 
-<enum name="ContextualSearchOptCardAction" type="int">
-  <int value="0" label="Opt-in"/>
-  <int value="1" label="Opt-out"/>
-  <int value="2" label="Learn More"/>
-  <int value="3" label="Dismiss by Tapping on the Page"/>
-  <int value="4" label="Dismiss by Scrolling the Page"/>
-  <int value="5" label="Dismiss by Leaving the Page"/>
-</enum>
-
-<enum name="ContextualSearchPeekCardAction" type="int">
-  <int value="0" label="Tap Card"/>
-  <int value="1" label="Dismiss by Tapping on the Page"/>
-  <int value="2" label="Dismiss by Scrolling the Page"/>
-  <int value="3" label="Dismiss by Leaving the Page"/>
-</enum>
-
-<enum name="ContextualSearchTapAction" type="int">
-  <int value="0" label="Tap Word"/>
-  <int value="1" label="Tap Ignored"/>
-  <int value="2" label="Tap Invalid"/>
-</enum>
-
 <enum name="CookieDeletionCause" type="int">
   <summary>Reason why a cookie was removed from the cookie store</summary>
   <int value="0" label="explicit">
@@ -51423,18 +51367,6 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="PLT.LoadType"/>
 </histogram_suffixes>
 
-<histogram_suffixes name="ContextualSearch">
-  <suffix name="Control"/>
-  <suffix name="Tap"/>
-  <suffix name="TapForced"/>
-  <affected-histogram name="Search.ContextualSearchOptCard"/>
-  <affected-histogram name="Search.ContextualSearchOptPeekCard"/>
-  <affected-histogram name="Search.ContextualSearchPeekCard"/>
-  <affected-histogram name="Search.ContextualSearchTap"/>
-  <affected-histogram name="Search.ContextualSearchTapUndecided"/>
-  <affected-histogram name="Search.ContextualSearchTimeToSearch"/>
-</histogram_suffixes>
-
 <histogram_suffixes name="CrosFirstRunStep" separator="">
   <suffix name="AppList"/>
   <suffix name="Tray"/>