Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 486233003: Trim down OSX GYP rules. Same effect, shorter. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Trim down OSX GYP rules. Same effect, shorter. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a34633f358ddde34577d653fea3bd41e66a7dde2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -59 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +15 lines, -59 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-19 16:08:44 UTC) #1
bungeman-skia
Why not? lgtm if it works.
6 years, 4 months ago (2014-08-19 20:04:44 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-19 20:19:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/486233003/1
6 years, 4 months ago (2014-08-19 20:20:24 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 20:33:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as a34633f358ddde34577d653fea3bd41e66a7dde2

Powered by Google App Engine
This is Rietveld 408576698