Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 48623008: Extract convert_dict target from chrome.gyp. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Extract convert_dict target from chrome.gyp. The gyp files under chrome/ are really not well organized, kind of a mess, so it is hard to find the right places to put things. As most of the things goes into browser, browser_ui or common libraries, this isn't much an issue though. But we can do better. BUG=None TEST=build/gyp_chromium chrome/tools/convert_dict/convert_dict.gyp ninja -C out/Debug convert_dict R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -36 lines) Patch
M chrome/chrome.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/tools/convert_dict/convert_dict.gyp View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Hi Lei, could you review this to me? Thanks,
7 years, 1 month ago (2013-11-01 00:15:57 UTC) #1
tfarina
ping??
7 years, 1 month ago (2013-11-01 21:55:56 UTC) #2
Lei Zhang
lgtm (was AFK yesterday -> lots of stuff to do today)
7 years, 1 month ago (2013-11-01 22:44:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48623008/1
7 years, 1 month ago (2013-11-01 23:11:49 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217894
7 years, 1 month ago (2013-11-02 02:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/48623008/1
7 years, 1 month ago (2013-11-02 02:28:33 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-02 05:20:31 UTC) #7
Message was sent while issue was closed.
Change committed as 232584

Powered by Google App Engine
This is Rietveld 408576698