Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/ic/x64/ic-compiler-x64.cc

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x64/ic-conventions-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/x64/ic-compiler-x64.cc
diff --git a/src/ic/x64/ic-compiler-x64.cc b/src/ic/x64/ic-compiler-x64.cc
index b2b02fb6909e686a6e161251c3fbe919b868e95d..8830009d8646a13d49bc88e12574888eff6fc44c 100644
--- a/src/ic/x64/ic-compiler-x64.cc
+++ b/src/ic/x64/ic-compiler-x64.cc
@@ -17,13 +17,14 @@ namespace internal {
void PropertyICCompiler::GenerateRuntimeSetProperty(MacroAssembler* masm,
StrictMode strict_mode) {
// Return address is on the stack.
- DCHECK(!rbx.is(StoreIC::ReceiverRegister()) &&
- !rbx.is(StoreIC::NameRegister()) && !rbx.is(StoreIC::ValueRegister()));
+ DCHECK(!rbx.is(StoreConvention::ReceiverRegister()) &&
+ !rbx.is(StoreConvention::NameRegister()) &&
+ !rbx.is(StoreConvention::ValueRegister()));
__ PopReturnAddressTo(rbx);
- __ Push(StoreIC::ReceiverRegister());
- __ Push(StoreIC::NameRegister());
- __ Push(StoreIC::ValueRegister());
+ __ Push(StoreConvention::ReceiverRegister());
+ __ Push(StoreConvention::NameRegister());
+ __ Push(StoreConvention::ValueRegister());
__ Push(Smi::FromInt(strict_mode));
__ PushReturnAddressFrom(rbx);
@@ -94,7 +95,7 @@ Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
// Polymorphic keyed stores may use the map register
Register map_reg = scratch1();
DCHECK(kind() != Code::KEYED_STORE_IC ||
- map_reg.is(KeyedStoreIC::MapRegister()));
+ map_reg.is(StoreConvention::MapRegister()));
__ movp(map_reg, FieldOperand(receiver(), HeapObject::kMapOffset));
int receiver_count = types->length();
int number_of_handled_maps = 0;
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x64/ic-conventions-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698