Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: src/ic/ic.h

Issue 486213003: Move register conventions out of the IC classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic-conventions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.h
diff --git a/src/ic/ic.h b/src/ic/ic.h
index f41bb9ae51f6f8cf5a16034c16af29c0b5f329c8..f759a0633775d143e30aa1c6db0cf872642980c1 100644
--- a/src/ic/ic.h
+++ b/src/ic/ic.h
@@ -352,15 +352,6 @@ OStream& operator<<(OStream& os, const CallIC::State& s);
class LoadIC : public IC {
public:
- enum ParameterIndices { kReceiverIndex, kNameIndex, kParameterCount };
- static const Register ReceiverRegister();
- static const Register NameRegister();
-
- // With flag vector-ics, there is an additional argument. And for calls from
- // crankshaft, yet another.
- static const Register SlotRegister();
- static const Register VectorRegister();
-
class State V8_FINAL BASE_EMBEDDED {
public:
explicit State(ExtraICState extra_ic_state) : state_(extra_ic_state) {}
@@ -531,16 +522,6 @@ class StoreIC : public IC {
// IC state.
static const ExtraICState kStrictModeState = 1 << StrictModeState::kShift;
- enum ParameterIndices {
- kReceiverIndex,
- kNameIndex,
- kValueIndex,
- kParameterCount
- };
- static const Register ReceiverRegister();
- static const Register NameRegister();
- static const Register ValueRegister();
-
StoreIC(FrameDepth depth, Isolate* isolate) : IC(depth, isolate) {
DCHECK(IsStoreStub());
}
@@ -630,11 +611,6 @@ class KeyedStoreIC : public StoreIC {
return ExtraICStateKeyedAccessStoreMode::decode(extra_state);
}
- // The map register isn't part of the normal call specification, but
- // ElementsTransitionAndStoreStub, used in polymorphic keyed store
- // stub implementations requires it to be initialized.
- static const Register MapRegister();
-
KeyedStoreIC(FrameDepth depth, Isolate* isolate) : StoreIC(depth, isolate) {
DCHECK(target()->is_keyed_store_stub());
}
« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic-conventions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698