Issue 486203004: Clean up WifiDataProvider(Manager)

Issue 486203004: Clean up WifiDataProvider(Manager) (Closed)

Created:
6 years, 4 months ago by Michael van Ouwerkerk

Modified:
6 years, 4 months ago

Reviewers:
timvolodine

CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Clean up WifiDataProvider(Manager) * No need to pass manager in callback * No need to keep pointer to manager in provider * Rename test methods Foo to FooForTesting Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291209

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't delete the DCHECK #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -35 lines)			Patch
M	content/browser/geolocation/network_location_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/network_location_provider.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/network_location_provider_unittest.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider.h	View		3 chunks	+1 line, -9 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider.cc	View		2 chunks	+4 lines, -8 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_common_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_manager.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_manager.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

Hi Tim, another Geolocation cleanup patch :-)

6 years, 4 months ago (2014-08-19 16:45:09 UTC) #1

timvolodine

lgtm https://codereview.chromium.org/486203004/diff/1/content/browser/geolocation/wifi_data_provider_manager.cc File content/browser/geolocation/wifi_data_provider_manager.cc (right): https://codereview.chromium.org/486203004/diff/1/content/browser/geolocation/wifi_data_provider_manager.cc#newcode70 content/browser/geolocation/wifi_data_provider_manager.cc:70: WifiDataProviderManager::~WifiDataProviderManager() { does it still need a DCHECK(impl_)?

6 years, 4 months ago (2014-08-20 16:05:40 UTC) #2

Michael van Ouwerkerk

Thanks Tim! https://codereview.chromium.org/486203004/diff/1/content/browser/geolocation/wifi_data_provider_manager.cc File content/browser/geolocation/wifi_data_provider_manager.cc (right): https://codereview.chromium.org/486203004/diff/1/content/browser/geolocation/wifi_data_provider_manager.cc#newcode70 content/browser/geolocation/wifi_data_provider_manager.cc:70: WifiDataProviderManager::~WifiDataProviderManager() { On 2014/08/20 16:05:40, timvolodine wrote: ...

6 years, 4 months ago (2014-08-21 15:46:23 UTC) #3

Michael van Ouwerkerk

The CQ bit was checked by mvanouwerkerk@chromium.org

6 years, 4 months ago (2014-08-21 15:46:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/486203004/20001

6 years, 4 months ago (2014-08-21 15:47:50 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 22:02:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 291209

Expand Messages | Collapse Messages