Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 486203003: Mojo JS bindings generator doesn't generate import-qualified struct references (Closed)

Created:
6 years, 4 months ago by hansmuller
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings generator doesn't generate import-qualified struct references The JS bindings generator maps '.mojom' files - not Mojo modules - to JS modules. Struct names that can be used without qualification in separate '.mojom' files (because both files specify the same Mojo module) must be JS-module qualified in the JS bindings. BUG=404788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290919

Patch Set 1 : #

Patch Set 2 : resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -32 lines) Patch
M mojo/mojo_public_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/rect.mojom View 1 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 1 chunk +2 lines, -7 lines 0 comments Download
M mojo/public/js/bindings/codec_unittests.js View 2 chunks +30 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 7 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
hansmuller
Fixed a JS bindings problem.
6 years, 4 months ago (2014-08-19 15:46:52 UTC) #1
Matt Perry
LGTM
6 years, 4 months ago (2014-08-19 18:51:03 UTC) #2
hansmuller
The CQ bit was checked by hansmuller@chromium.org
6 years, 4 months ago (2014-08-20 15:13:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hansmuller@chromium.org/486203003/20001
6 years, 4 months ago (2014-08-20 15:14:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 15:25:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 15:26:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44169) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/7343) ios_rel_device ...
6 years, 4 months ago (2014-08-20 15:26:52 UTC) #7
hansmuller
The CQ bit was checked by hansmuller@chromium.org
6 years, 4 months ago (2014-08-20 16:42:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hansmuller@chromium.org/486203003/20001
6 years, 4 months ago (2014-08-20 16:43:46 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 16:55:35 UTC) #10
hansmuller
The CQ bit was checked by hansmuller@chromium.org
6 years, 4 months ago (2014-08-20 16:57:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hansmuller@chromium.org/486203003/40001
6 years, 4 months ago (2014-08-20 16:58:23 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 18:56:36 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 19:44:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/712)
6 years, 4 months ago (2014-08-20 19:44:16 UTC) #15
hansmuller
The CQ bit was checked by hansmuller@chromium.org
6 years, 4 months ago (2014-08-20 19:51:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hansmuller@chromium.org/486203003/40001
6 years, 4 months ago (2014-08-20 19:53:08 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 20:56:48 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 21:36:48 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (40001) as 290919

Powered by Google App Engine
This is Rietveld 408576698