Do not switch the ICU locale when interacting with public session pods

chrome/browser/ui/webui/chromeos/login/l10n_util.cc

Index: chrome/browser/ui/webui/chromeos/login/l10n_util.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
index efbc1dcffc95ad97481dd4696bdeb7c1a72bcad0..76ddcfe28a50bde43f74ef4857852d42e460c8c8 100644
--- a/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
+++ b/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
@@ -459,13 +459,13 @@ void GetKeyboardLayoutsForLocale(
 
   // Resolve |locale| on a background thread, then continue on the current
   // thread.
+  std::string (*get_application_locale)(const std::string&, bool) =
+      &l10n_util::GetApplicationLocale;

[tony, 2014/08/19 18:44:49]

Do you have access to g_browser_process or does that not exist for the login
screen?  If you have access to g_browser_process, you should use 
g_browser_process->GetApplicationLocale() instead of
l10n_util::GetApplicationLocale.

[bartfab (slow), 2014/08/20 08:46:25]

I do have access to g_browser_process but the semantics of
g_browser_process->GetApplicationLocale() (1) and those of
l10n_util::GetApplicationLocale() (1) are different:

(1) will return the current locale. This is of no interest to me.
(2) will check whether the locale passed in as a string is valid and if so,
return it. If the locale is not valid, it will fall back to en-US.

I need the semantics of (2), not (1).

   base::PostTaskAndReplyWithResult(
       background_task_runner,
       FROM_HERE,
-      base::Bind(&l10n_util::GetApplicationLocale,
-                 locale),
-      base::Bind(&GetKeyboardLayoutsForResolvedLocale,
-                 callback));
+      base::Bind(get_application_locale, locale, false /* set_icu_locale*/ ),
+      base::Bind(&GetKeyboardLayoutsForResolvedLocale, callback));
 }
 
 scoped_ptr<base::DictionaryValue> GetCurrentKeyboardLayout() {