Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 486153002: Move AppWindow related classes to extensions (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move AppWindow related classes to extensions Move AppDelegate, AppWebContentsHelper and AppWindowGeometryCache to extensions/browser/app_window Change the namespace from apps to extensions. BUG=403726 R=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290796

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Undo web_contents_sizer #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1211 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D apps/app_delegate.h View 1 2 3 1 chunk +0 lines, -74 lines 0 comments Download
D apps/app_web_contents_helper.h View 1 chunk +0 lines, -76 lines 0 comments Download
M apps/app_web_contents_helper.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M apps/app_window.h View 1 2 3 4 4 chunks +5 lines, -6 lines 0 comments Download
M apps/app_window.cc View 1 2 3 4 7 chunks +10 lines, -10 lines 0 comments Download
D apps/app_window_geometry_cache.h View 1 chunk +0 lines, -162 lines 0 comments Download
D apps/app_window_geometry_cache.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D apps/app_window_geometry_cache_unittest.cc View 1 chunk +0 lines, -365 lines 0 comments Download
M apps/apps.gypi View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M apps/browser_context_keyed_service_factories.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/custom_launcher_page_contents.h View 3 chunks +7 lines, -5 lines 0 comments Download
M apps/custom_launcher_page_contents.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_window_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A + extensions/browser/app_window/app_delegate.h View 1 2 3 4 chunks +8 lines, -10 lines 0 comments Download
A + extensions/browser/app_window/app_web_contents_helper.h View 4 chunks +6 lines, -9 lines 0 comments Download
A + extensions/browser/app_window/app_web_contents_helper.cc View 5 chunks +9 lines, -9 lines 0 comments Download
A + extensions/browser/app_window/app_window_geometry_cache.h View 5 chunks +13 lines, -17 lines 0 comments Download
A + extensions/browser/app_window/app_window_geometry_cache.cc View 6 chunks +12 lines, -15 lines 0 comments Download
A + extensions/browser/app_window/app_window_geometry_cache_unittest.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-19 11:07:59 UTC) #1
hashimoto
Seems web_contents_sizer cannot be placed under extensions because Android needs it. Reverted web_contents_sizer related changes.
6 years, 4 months ago (2014-08-20 03:50:53 UTC) #2
benwells
lgtm
6 years, 4 months ago (2014-08-20 05:32:14 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-20 06:35:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/486153002/180001
6 years, 4 months ago (2014-08-20 06:35:57 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 06:44:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 06:46:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/4954)
6 years, 4 months ago (2014-08-20 06:46:38 UTC) #8
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-20 07:23:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/486153002/10019
6 years, 4 months ago (2014-08-20 07:24:17 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 09:01:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 09:04:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/3588)
6 years, 4 months ago (2014-08-20 09:04:46 UTC) #13
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-20 09:29:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/486153002/210001
6 years, 4 months ago (2014-08-20 09:31:04 UTC) #15
hashimoto
6 years, 4 months ago (2014-08-20 09:40:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 manually as 290796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698