Chromium Code Reviews

Issue 486133002: Revert of [XHR] Reduce 'readystatechange' event firing. (Closed)

Created:
6 years, 4 months ago by yhirano
Modified:
6 years, 4 months ago
Reviewers:
tyoshino (SeeGerritForStatus), tkent, yhirano1
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [XHR] Reduce 'readystatechange' event firing. (patchset #9 of https://codereview.chromium.org/428473005/) Reason for revert: This change breaks legacy applications. Original issue's description: > [XHR] Reduce 'readystatechange' event firing. > > Currently too many readystatechange events are fired and > it hurts performance. > > BUG=336066 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179381 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180554

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+6 lines, -23 lines)
M Source/core/xml/XMLHttpRequest.h View 1 chunk +0 lines, -2 lines 0 comments
M Source/core/xml/XMLHttpRequest.cpp View 3 chunks +6 lines, -21 lines 2 comments

Messages

Total messages: 18 (0 generated)
yhirano
Created Revert of [XHR] Reduce 'readystatechange' event firing.
6 years, 4 months ago (2014-08-19 08:16:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/486133002/1
6 years, 4 months ago (2014-08-19 08:16:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 08:16:35 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-19 08:16:36 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-19 08:19:49 UTC) #5
tkent
lgtm
6 years, 4 months ago (2014-08-19 08:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/486133002/1
6 years, 4 months ago (2014-08-19 08:21:07 UTC) #7
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/486133002/diff/70001/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/486133002/diff/70001/Source/core/xml/XMLHttpRequest.cpp#newcode443 Source/core/xml/XMLHttpRequest.cpp:443: // Firefox calls readyStateChanged every time it receives ...
6 years, 4 months ago (2014-08-19 10:22:17 UTC) #8
yhirano1
https://codereview.chromium.org/486133002/diff/70001/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/486133002/diff/70001/Source/core/xml/XMLHttpRequest.cpp#newcode443 Source/core/xml/XMLHttpRequest.cpp:443: // Firefox calls readyStateChanged every time it receives data. ...
6 years, 4 months ago (2014-08-19 10:34:51 UTC) #9
yhirano1
The CQ bit was checked by yhirano@google.com
6 years, 4 months ago (2014-08-19 10:35:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/486133002/70001
6 years, 4 months ago (2014-08-19 10:36:04 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-19 11:42:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 12:22:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23421)
6 years, 4 months ago (2014-08-19 12:22:31 UTC) #14
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-19 12:46:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/486133002/70001
6 years, 4 months ago (2014-08-19 12:46:24 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-19 13:28:42 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 14:09:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (70001) as 180554

Powered by Google App Engine