Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 486123002: Fix Android build. (Closed)

Created:
6 years, 4 months ago by ulan
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/android.gypi View 1 chunk +0 lines, -1 line 1 comment Download
M test/compiler-unittests/instruction-selector-unittest.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL https://codereview.chromium.org/486123002/diff/1/build/android.gypi File build/android.gypi (left): https://codereview.chromium.org/486123002/diff/1/build/android.gypi#oldcode90 build/android.gypi:90: '-U__linux__', # Don't allow toolchain to claim -D__linux__ ...
6 years, 4 months ago (2014-08-19 08:09:02 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-19 08:15:48 UTC) #2
ulan
6 years, 4 months ago (2014-08-19 08:27:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698