Issue 486123002: Fix Android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 486123002: Fix Android build. (Closed)

Created:
6 years, 4 months ago by ulan

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix Android build. BUG=v8:3506 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23181

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	build/android.gypi	View		1 chunk	+0 lines, -1 line	1 comment	Download
	M	test/compiler-unittests/instruction-selector-unittest.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

PTAL https://codereview.chromium.org/486123002/diff/1/build/android.gypi File build/android.gypi (left): https://codereview.chromium.org/486123002/diff/1/build/android.gypi#oldcode90 build/android.gypi:90: '-U__linux__', # Don't allow toolchain to claim -D__linux__ ...

6 years, 4 months ago (2014-08-19 08:09:02 UTC) #1

ulan

6 years, 4 months ago (2014-08-19 08:27:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23181 (presubmit successful).

Expand Messages | Collapse Messages