Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: pkg/analysis_server/test/analysis/notification_errors_test.dart

Issue 486003003: Start using code-generated protocol classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_errors_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_errors_test.dart b/pkg/analysis_server/test/analysis/notification_errors_test.dart
index bb663744e26798e7e2705b105320e89d2b40acae..1809096c772390044794517f01a014c2105659eb 100644
--- a/pkg/analysis_server/test/analysis/notification_errors_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_errors_test.dart
@@ -4,10 +4,10 @@
library test.analysis.notification_errors;
-import 'package:analysis_server/src/computer/error.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_analysis.dart';
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:unittest/unittest.dart';
@@ -26,9 +26,8 @@ class NotificationErrorsTest extends AbstractAnalysisTest {
void processNotification(Notification notification) {
if (notification.event == ANALYSIS_ERRORS) {
- String file = notification.getParameter(FILE);
- List<Map<String, Object>> errorMaps = notification.getParameter(ERRORS);
- filesErrors[file] = errorMaps.map(AnalysisError.fromJson).toList();
+ var decoded = new AnalysisErrorsParams.fromNotification(notification);
+ filesErrors[decoded.file] = decoded.errors;
}
}
@@ -48,8 +47,8 @@ class NotificationErrorsTest extends AbstractAnalysisTest {
expect(error.location.file, '/project/bin/test.dart');
expect(error.location.offset, isPositive);
expect(error.location.length, isNonNegative);
- expect(error.severity, 'ERROR');
- expect(error.type, 'SYNTACTIC_ERROR');
+ expect(error.severity, ErrorSeverity.ERROR);
+ expect(error.type, ErrorType.SYNTACTIC_ERROR);
expect(error.message, isNotNull);
});
}
@@ -65,8 +64,8 @@ main() {
List<AnalysisError> errors = filesErrors[testFile];
expect(errors, hasLength(1));
AnalysisError error = errors[0];
- expect(error.severity, 'WARNING');
- expect(error.type, 'STATIC_WARNING');
+ expect(error.severity, ErrorSeverity.WARNING);
+ expect(error.type, ErrorType.STATIC_WARNING);
});
}
« no previous file with comments | « pkg/analysis_server/test/analysis/get_errors_test.dart ('k') | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698